feat: Add kernel language model service by grypez · Pull Request #586 · MetaMask/ocap-kernel

grypez · 2025-08-07T16:57:04Z

Lays out a strategy for language model integration into the ocap-kernel.

Changes

New package: @ocap/kernel-language-model-service. Implementation-specific dependencies are isolated into distinct exports.

`@ocap/kernel-language-model-service`

Provides a streaming language model interface. There is a makeInstance method, which returns an object with a sample method. The name sample is chosen to align with the semantics of sample in the model context protocol¹.
Provides a nodejs ollama client implementation, OllamaNodejsService.
Adds an e2e test which can be used to connect to and test integration with an ollama server running locally on the development workstation.

Note to Reviewers

An unused 'archetypes' abstraction was removed because it was out of scope. Good model selection for a task depends on both the details of the request and the execution context. The kernel-language-model-service package provides basic integrations against a uniform interface that nods to MCP and satisfies eventual-send.

https://modelcontextprotocol.io/specification/2025-06-18/client/sampling ↩

socket-security · 2025-08-07T17:00:16Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Quality	Maintenance
	@unrs/resolver-binding-android-arm-eabi@1.11.1
	@unrs/resolver-binding-android-arm64@1.11.1
	@unrs/resolver-binding-darwin-arm64@1.7.0 ⏵ 1.11.1			^-4
	@unrs/resolver-binding-darwin-x64@1.7.0 ⏵ 1.11.1			^-4
	@unrs/resolver-binding-freebsd-x64@1.7.0 ⏵ 1.11.1			^-4
	@unrs/resolver-binding-linux-arm-gnueabihf@1.7.0 ⏵ 1.11.1			^-4
	@unrs/resolver-binding-linux-arm-musleabihf@1.7.0 ⏵ 1.11.1			^-4
	@unrs/resolver-binding-linux-arm64-gnu@1.7.0 ⏵ 1.11.1			^-4
	@unrs/resolver-binding-linux-arm64-musl@1.7.0 ⏵ 1.11.1			^-4
	@unrs/resolver-binding-linux-ppc64-gnu@1.7.0 ⏵ 1.11.1			^-4
	@unrs/resolver-binding-linux-riscv64-gnu@1.7.0 ⏵ 1.11.1			^-4
	@unrs/resolver-binding-linux-riscv64-musl@1.7.0 ⏵ 1.11.1			^-4
	@unrs/resolver-binding-linux-s390x-gnu@1.7.0 ⏵ 1.11.1			^-4
	@unrs/resolver-binding-linux-x64-gnu@1.7.0 ⏵ 1.11.1			^-2
	@unrs/resolver-binding-linux-x64-musl@1.7.0 ⏵ 1.11.1			^-3
	@unrs/resolver-binding-win32-arm64-msvc@1.7.0 ⏵ 1.11.1			^-4
	@unrs/resolver-binding-win32-ia32-msvc@1.7.0 ⏵ 1.11.1			^-4
	@unrs/resolver-binding-win32-x64-msvc@1.7.0 ⏵ 1.11.1			^-4
	@unrs/resolver-binding-wasm32-wasi@1.7.0 ⏵ 1.11.1	⁺¹	⁺¹	^-4
	@typescript-eslint/visitor-keys@8.38.0
	@typescript-eslint/parser@8.38.0
	@typescript-eslint/project-service@8.38.0
	@napi-rs/wasm-runtime@0.2.9 ⏵ 0.2.12	⁺¹	⁺¹
	@emnapi/runtime@1.4.3 ⏵ 1.4.5
	@typescript-eslint/type-utils@8.38.0
	@typescript-eslint/types@8.38.0
	@emnapi/core@1.4.3 ⏵ 1.4.5
	@typescript-eslint/scope-manager@8.38.0
	@typescript-eslint/typescript-estree@8.38.0
	@typescript-eslint/eslint-plugin@8.38.0
	@tybys/wasm-util@0.9.0 ⏵ 0.10.0	⁺¹	⁺¹
	ignore@7.0.5
See 5 more rows in the dashboard

View full report

socket-security · 2025-08-07T17:00:18Z

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

ollama@0.5.17
unrs-resolver@1.11.1

View full report

grypez · 2025-08-11T12:40:34Z

@SocketSecurity ignore ollama@0.5.17

To be addressed by an endowment management solution.

grypez · 2025-08-11T12:45:06Z

@SocketSecurity ignore npm/prettier@3.6.2

This dev dependency is an acceptable risk.

grypez · 2025-08-11T12:49:44Z

@SocketSecurity ignore npm/unrs-resolver@1.11.1

The install script is disabled by lavamoat in the monorepo package.json.

…vice

… fetch

sirtimid

Nice one! A couple of things to change but the other nits

…tness

sirtimid

LG

grypez force-pushed the grypez/kernel-language-model-service branch from 5c11916 to 31b004f Compare August 8, 2025 14:41

grypez force-pushed the grypez/kernel-language-model-service branch 3 times, most recently from 46097da to 9aa4bb2 Compare August 11, 2025 15:09

grypez marked this pull request as ready for review August 11, 2025 16:45

grypez requested a review from a team as a code owner August 11, 2025 16:45

grypez force-pushed the grypez/kernel-language-model-service branch from e93bd66 to 2a0ef39 Compare August 12, 2025 12:09

This comment was marked as outdated.

Sign in to view

grypez force-pushed the grypez/kernel-language-model-service branch from 2a0ef39 to a21cc75 Compare August 12, 2025 12:51

This comment was marked as outdated.

Sign in to view

grypez added 6 commits August 12, 2025 09:17

feat(kernel-language-model-service): Create package from template

6000e82

feat(kernel-language-model-service): Add OllamaNodejsLanguageModelSer…

2e7910a

…vice

feat(kernel-language-model-service): Construct Ollama with restricted…

e83f88a

… fetch

build(kernel-language-model-service): Link fetch type

cb03117

feat(kernel-language-model-service): Eventualize LanguageModel interface

5e6e633

remove archetype abstraction

65777e9

grypez force-pushed the grypez/kernel-language-model-service branch from a21cc75 to 65777e9 Compare August 12, 2025 13:18

sirtimid requested changes Aug 12, 2025

View reviewed changes

grypez added 7 commits August 12, 2025 10:44

use superstruct parsing

0a0ee43

test(kernel-language-model-service): setup (mock) endoify

795493a

feat(kernel-language-model-service): Apply type suggestions

8412e8a

test(kernel-language-model-service): Improve e2e coverage

12890dc

shorten names

4f69c0f

feat(kernel-language-model-service): Improve restricted fetch explici…

2ede7de

…tness

docs(kernel-language-model-service): Audit docstrings

67d092a

grypez added 2 commits August 12, 2025 12:13

docs(kernel-language-model-service): Update README

065a442

fix fetch default argument

01c2854

This comment was marked as outdated.

Sign in to view

grypez requested a review from sirtimid August 12, 2025 16:58

sirtimid previously approved these changes Aug 12, 2025

View reviewed changes

grypez changed the title ~~feat: Add kernel language model service~~ feat: Add language model service Aug 12, 2025

grypez dismissed sirtimid’s stale review via 01c2854 August 12, 2025 17:52

grypez force-pushed the grypez/kernel-language-model-service branch from 6668f20 to 01c2854 Compare August 12, 2025 17:52

grypez changed the title ~~feat: Add language model service~~ feat: Add kernel language model service Aug 12, 2025

grypez enabled auto-merge (squash) August 12, 2025 17:54

sirtimid approved these changes Aug 12, 2025

View reviewed changes

grypez merged commit a5c2f60 into main Aug 12, 2025
41 checks passed

grypez deleted the grypez/kernel-language-model-service branch August 12, 2025 18:09

Conversation

grypez commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

@ocap/kernel-language-model-service

Note to Reviewers

Footnotes

Uh oh!

socket-security Bot commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security Bot commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

grypez commented Aug 11, 2025

Uh oh!

grypez commented Aug 11, 2025

Uh oh!

grypez commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

sirtimid left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

sirtimid left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

grypez commented Aug 7, 2025 •

edited

Loading

`@ocap/kernel-language-model-service`

socket-security Bot commented Aug 7, 2025 •

edited

Loading

socket-security Bot commented Aug 7, 2025 •

edited

Loading

grypez commented Aug 11, 2025 •

edited

Loading